[clang] Refactor to remove clangDriver dependency from clangFrontend and flangFrontend #165277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveen-seth
requested review from
JDevlieghere,
aaronmondal,
cyndyishida,
keith and
rupprecht
as code owners
llvmbot
added
clang
naveen-seth
force-pushed
the
removeDriverDepFromFrontend
branch
from
65b3857 to
49db4fc
Compare
naveen-seth
force-pushed
the
removeDriverDepFromFrontend
branch
from
49db4fc to
6380c54
Compare
|
Note: Linux AArch64 CI is currently having trouble (failing everywhere), which is why this isn't passing all checks. |
naveen-seth
force-pushed
the
removeDriverDepFromFrontend
branch
3 times, most recently
from
7dd2dd8 to
cc10a13
Compare
naveen-seth
changed the title
|
I've tested this with |
kiranchandramohan
requested review from
DavidTruby,
banach-space,
tarunprabhu and
tblah
flang/lib/Frontend/CMakeLists.txt
Outdated
|
|
||
| CLANG_LIBS | ||
| clangBasic | ||
| clangDriver |
There was a problem hiding this comment.
Reading the title of the patch I was hoping that you could remove the clangDriver dependency from flangFrontend as well. Any reason you could not remove?
There was a problem hiding this comment.
Done, and thanks for pointing that out!
…ns library This change moves option-related code from clangDriver into a new clangOptions library. This refactoring is part of a broader effort to support driver-managed builds for compilations using C++ named modules and/or Clang modules. It is required for linking the dependency scanning tooling against the driver without introducing cyclic dependencies, which would otherwise cause build failures when dynamic linking is enabled. In particular, clangFrontend must no longer depend on clangDriver for this to be possible. This PR is motivated by the following review comment: llvm#152770 (comment)
This PR removes the clangDriver dependency from clangFrontend. The goal of this change is to remove dependencies on the Driver. This refactoring is part of a broader effort to support driver-managed builds for compilations using C++ named modules and/or Clang modules. It is required for linking the dependency scanning tooling against the driver without introducing cyclic dependencies, which would otherwise cause build failures when dynamic linking is enabled. In particular, clangFrontend must no longer depend on clangDriver for this to be possible. This change is motivated by the following review comment: llvm#152770 (comment)
naveen-seth
force-pushed
the
removeDriverDepFromFrontend
branch
from
e978ccd to
080ace2
Compare
naveen-seth
changed the title
tarunprabhu
reviewed
Nov 3, 2025
|
[EDIT] Just noticed the typo in the title:
|
naveen-seth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on
clangDriverfromclangFrontendandflangFrontendThis refactoring is part of a broader effort to support driver-managed builds for compilations using C++ named modules and/or Clang modules.
It is required for linking the dependency scanning tooling against the driver without introducing cyclic dependencies, which would otherwise cause build failures when dynamic linking is enabled.
In particular,
clangFrontendmust no longer depend onclangDriverfor this to be possible.This change is motivated by the following review comment: #152770 (comment)